Should I be watching French films with French subtitles or English subtitles?

I definitely recommed watching with subtitles in the target language. Even if you don't understand everything it is a really good way to recognise vocabulary and improve your accent for certain words.