What are the products when an acid reacts with a metal?

An acid and metal react to form hydrogen and a salt.
For example:
Mg + 2HCl ----> MgCl2 + H2
1 mole of magnesium reacts with 2 moles of hydrochloric acid to form 1 mole of magnesium chloride and 1 mole of hydrogen.